Add DMA for sending email (revisit #217)#288
Open
moqmar wants to merge 5 commits intothecodingmachine:v4from
Open
Add DMA for sending email (revisit #217)#288moqmar wants to merge 5 commits intothecodingmachine:v4from
moqmar wants to merge 5 commits intothecodingmachine:v4from
Conversation
Author
|
FYI, I'm getting the same issue in the actions when running |
Collaborator
|
First, thx you for your PR, @moqmar. I checked and seem a good implementation for all requirement. I may don't have time this week to manage this issue bug the reporter said he may fix it. If not, i will try to do it at end of next week. |
mistraloz
approved these changes
Feb 8, 2022
1515ff2 to
799d10e
Compare
|
Are there any updates on this one? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement solution for email sending, as discussed in #204 and also attempted earlier in #217 for v3.
This PR implements the following features
build-and-test.shExplain the motivation for making this change. What existing problem does the pull request solve?
Most PHP hosters make the "mail()" function usable, so many PHP application expect it to be usable. With this image, those applications were unable to send email.
Test plan (required)
See
build-and-test.sh, the commands from there can also be run manually; the mails sent with the demo credentials can be viewed on https://ethereal.email/messages.Closing issues
Fixes #204
Checklist